safe-global / safe-core-sdk / 10010475373

78%

main: 78%

push

github

fix(api-kit): Fix e2e tests for multisig transactions (#919)

* Fix + improve the confirm transaction e2e test

The test was incorrect because it used the same transaction hash repeatedly, leading to assertions being made on an already confirmed transaction instead of a newly proposed one. By adding a timestamp to the transaction data, we ensure that each transaction hash is unique.

Additionally, the test incorrectly called the `isValidSignature` function with a transaction hash. This function is intended only for messages, causing the contract call to fail consistently. However, the error was not properly caught; the function merely returns `false` when an error occurs. With the migration to viem, the `isValidSignature` contract call sometimes takes too long to fail, resulting in occasional test timeouts. By removing the incorrect call, we prevent those timeout errors.

* Fix tests by using another Safe address that is not used by the confirmTransaction test

221 of 367 branches covered (60.22%)

Branch coverage included in aggregate %.

787 of 985 relevant lines covered (79.9%)

3.03 hits per line