c-ares / c-ares / #1274

82%

main: 92%

Build Type

push

travis-ci

Committed by bradh352

Commit Message

Prevent complex recursion during query requeing and connection cleanup

c-ares utilizes recursion for some operations, and some of these
processes can have unintended side effects, such as if a callback
is called that then recurses into the same function. This can cause
strange cleanup conditions that lead to crashes.

Try to disassociate queries with connections as early as possible and
move cleaning up unneeded connections to its own scan rather than
trying to detect each time a query is disassociated from a connection.

Fix By: Brad House (@bradh352)

Run Details

34 of 35 new or added lines in 3 files covered. (97.14%)

5 existing lines in 1 file now uncovered.

7665 of 9298 relevant lines covered (82.44%)

1971.66 hits per line