c-ares / c-ares / #1273

81%

main: 92%

push

travis-ci

Prevent complex recursion during query requeing and connection cleanup

c-ares utilizes recursion for some operations, and some of these
processes can have unintended side effects, such as if a callback
is called that then recurses into the same function. This can cause
strange cleanup conditions that lead to crashes.

Try to disassociate queries with connections as early as possible and
move cleaning up unneeded connections to its own scan rather than
trying to detect each time a query is disassociated from a connection.

Fix By: Brad House (@bradh352)

34 of 35 new or added lines in 3 files covered. (97.14%)

7739 of 9594 relevant lines covered (80.66%)

1935.18 hits per line