#4078

Committed 19 Jul 2024 01:17PM UTC coverage: 48.987% (-0.001%) from 48.988%

Build # #4078

Build Type

push

github

Committed by

adangel

Commit Message

Merge remote-tracking branch 'origin/master'

Run Details

31831 of 71106 branches covered (44.77%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

67955 of 132592 relevant lines covered (51.25%)

0.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.64

/pmd-javascript/src/main/java/net/sourceforge/pmd/lang/ecmascript/ast/ASTNumberLiteral.java

/*
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.ecmascript.ast;

import java.math.BigDecimal;

import org.mozilla.javascript.ast.NumberLiteral;

public final class ASTNumberLiteral extends AbstractEcmascriptNode<NumberLiteral> {
    ASTNumberLiteral(NumberLiteral numberLiteral) {
        super(numberLiteral);
    }

    @Override
    protected <P, R> R acceptJsVisitor(EcmascriptVisitor<? super P, ? extends R> visitor, P data) {
        return visitor.visit(this, data);
    }

    public String getNormalizedImage() {
        String image = getValue();
        image = image.replaceAll("_", "");
        image = normalizeHexIntegerLiteral(image);
        image = normalizeBinaryLiteral(image);
        image = normalizeOctalLiteral(image);
        image = image.replace('e', 'E');
        if (image.indexOf('.') == -1 && image.indexOf('E') == -1) {
            image = image + ".0";
        }
        return image;
    }

    private String normalizeHexIntegerLiteral(String image) {
        if (image.startsWith("0x") || image.startsWith("0X")) {
            return String.valueOf(Integer.parseInt(image.substring(2), 16));
        }
        return image;
    }

    private String normalizeBinaryLiteral(String image) {
        if (image.startsWith("0b") || image.startsWith("0B")) {
            return String.valueOf(Integer.parseInt(image.substring(2), 2));
        }
        return image;
    }

    private String normalizeOctalLiteral(String image) {
        if (image.startsWith("0o") || image.startsWith("0O")) {
            return String.valueOf(Integer.parseInt(image.substring(2), 8));
        }
        return image;
    }

    public double getNumber() {
        return node.getNumber();
    }

    public String getValue() {
        return node.getValue();
    }

    /**
     * Checks if this number literal cannot be represented exactly without loss as
     * a JavaScript Number. The number is either too big or uses too many decimal places.
     * @return {@code true} if the literal is inaccurate.
     * @since 7.4.0
     */
    public boolean isInaccurate() {
        BigDecimal bigDecimal = new BigDecimal(getNormalizedImage());
        BigDecimal converted = BigDecimal.valueOf(bigDecimal.doubleValue());
        return bigDecimal.compareTo(converted) != 0;
    }
}

1	/*
2	* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3	*/
4
5	package net.sourceforge.pmd.lang.ecmascript.ast;
6
7	import java.math.BigDecimal;
8
9	import org.mozilla.javascript.ast.NumberLiteral;
10
11	public final class ASTNumberLiteral extends AbstractEcmascriptNode<NumberLiteral> {
12	ASTNumberLiteral(NumberLiteral numberLiteral) {
13	super(numberLiteral);	1✔
14	}	1✔
15
16	@Override
17	protected <P, R> R acceptJsVisitor(EcmascriptVisitor<? super P, ? extends R> visitor, P data) {
18	return visitor.visit(this, data);	1✔
19	}
20
21	public String getNormalizedImage() {
22	String image = getValue();	1✔
23	image = image.replaceAll("_", "");	1✔
24	image = normalizeHexIntegerLiteral(image);	1✔
25	image = normalizeBinaryLiteral(image);	1✔
26	image = normalizeOctalLiteral(image);	1✔
27	image = image.replace('e', 'E');	1✔
28	if (image.indexOf('.') == -1 && image.indexOf('E') == -1) {	1!
29	image = image + ".0";	1✔
30	}
31	return image;	1✔
32	}
33
34	private String normalizeHexIntegerLiteral(String image) {
35	if (image.startsWith("0x") \|\| image.startsWith("0X")) {	1!
36	return String.valueOf(Integer.parseInt(image.substring(2), 16));	1✔
37	}
38	return image;	1✔
39	}
40
41	private String normalizeBinaryLiteral(String image) {
42	if (image.startsWith("0b") \|\| image.startsWith("0B")) {	1!
43	return String.valueOf(Integer.parseInt(image.substring(2), 2));	1✔
44	}
45	return image;	1✔
46	}
47
48	private String normalizeOctalLiteral(String image) {
49	if (image.startsWith("0o") \|\| image.startsWith("0O")) {	1!
50	return String.valueOf(Integer.parseInt(image.substring(2), 8));	1✔
51	}
52	return image;	1✔
53	}
54
55	public double getNumber() {
UNCOV 56	return node.getNumber();	×
57	}
58
59	public String getValue() {
60	return node.getValue();	1✔
61	}
62
63	/**
64	* Checks if this number literal cannot be represented exactly without loss as
65	* a JavaScript Number. The number is either too big or uses too many decimal places.
66	* @return {@code true} if the literal is inaccurate.
67	* @since 7.4.0
68	*/
69	public boolean isInaccurate() {
70	BigDecimal bigDecimal = new BigDecimal(getNormalizedImage());	1✔
71	BigDecimal converted = BigDecimal.valueOf(bigDecimal.doubleValue());	1✔
72	return bigDecimal.compareTo(converted) != 0;	1✔
73	}
74	}

pmd / pmd / #4078

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous