9988321408

Committed 18 Jul 2024 08:39AM UTC coverage: 57.299% (+0.6%) from 56.679%

Build # 9988321408

Build Type

push

github

Committed by

web-flow

Commit Message

marge develop into main (#1890)

* add cron test

* fix yaml

* fix yaml

* update spacing

* use example

* update cron

* update to push

* add 2am cron

* update yaml

* use utc

* add first update

* add populate function

* add changelog

* update tests

* fix test

* attempt to fix test

* interim

* interim

* add label

* add description field

* add vertical scaling

* working UI

* add tooltips

* working ui

* add to cignorelist

* add changelog entry

* tidy up

* fix typo

* fix codeql

* Task/rdmp-1  Update Ticketing System (#1870)

* add initial ticketing update

* fix patch

* interim

* allow blanks

* pass statuses around

* update tests

* add image

* add resources

* tidy up

* tidy up

* fix build

* add icon

* add image

* fix test

* add changelog

* fix error not poping

* add missing line

* fix typo

* tidy up

* Bump ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5

Bumps ObjectListView.Repack.NET6Plus from 2.9.4 to 2.9.5.

---
updated-dependencies:
- dependency-name: ObjectListView.Repack.NET6Plus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Terminal.Gui from 1.17.0 to 1.17.1 (#1879)

Bumps Terminal.Gui from 1.17.0 to 1.17.1.

---
updated-dependencies:
- dependency-name: Terminal.Gui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-dotnet from 4.0.0 to 4.0.1 (#1875)

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](https://github.com/actions/setup-dotnet/compare/v4.0.0...v4.0.1)

---... (continued)

Run Details

11072 of 20790 branches covered (53.26%)

Branch coverage included in aggregate %.

49 of 83 new or added lines in 17 files covered. (59.04%)

45 existing lines in 12 files now uncovered.

31313 of 53181 relevant lines covered (58.88%)

7890.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Rdmp.Core/Ticketing/SimpleTicketingSystem.cs

﻿// Copyright (c) The University of Dundee 2018-2019
// This file is part of the Research Data Management Platform (RDMP).
// RDMP is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
// RDMP is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
// You should have received a copy of the GNU General Public License along with RDMP. If not, see <https://www.gnu.org/licenses/>.

using System;
using System.Collections.Generic;
using Rdmp.Core.Curation;
using Rdmp.Core.ReusableLibraryCode;
using Rdmp.Core.ReusableLibraryCode.Checks;
using Rdmp.Core.ReusableLibraryCode.DataAccess;

namespace Rdmp.Core.Ticketing;

/// <summary>
/// Simple implementation of an RDMP ticketing system.  Opens a browser
/// at the Url + ticket name.  Has no validation restrictions based on
/// ticket states.
/// </summary>
public class SimpleTicketingSystem : ICheckable, ITicketingSystem
{
    protected IDataAccessCredentials Credentials { get; set; }
    protected string Url { get; set; }

    protected SimpleTicketingSystem(TicketingSystemConstructorParameters parameters)
    {
        Credentials = parameters.Credentials;
        Url = parameters.Url;
    }

    public void Check(ICheckNotifier notifier)
    {
        // all ticket names are valid
    }

    public bool IsValidTicketName(string ticketName) =>
        // all ticket names are valid
        true;

    public void NavigateToTicket(string ticketName)
    {
        // if the user has added a URL just append the ticket name to it
        // and open e.g. "www.myticketing?q=" + "HDD-123"
        if (!string.IsNullOrWhiteSpace(Url))
            UsefulStuff.OpenUrl(Url + ticketName);
    }

    public TicketingReleaseabilityEvaluation GetDataReleaseabilityOfTicket(string masterTicket, string requestTicket,
        string releaseTicket, List<TicketingSystemReleaseStatus> acceptedStatuses, out string reason, out Exception exception)
    {
        reason = null;
        exception = null;
        // No restrictions on releasability
        return TicketingReleaseabilityEvaluation.Releaseable;
    }

    public string GetProjectFolderName(string masterTicket) =>
        UsefulStuff.RegexThingsThatAreNotNumbersOrLettersOrUnderscores.Replace(masterTicket, "");

    public List<string> GetAvailableStatuses()
    {
        return new List<string>();
    }
}

1	// Copyright (c) The University of Dundee 2018-2019
2	// This file is part of the Research Data Management Platform (RDMP).
3	// RDMP is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
4	// RDMP is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
5	// You should have received a copy of the GNU General Public License along with RDMP. If not, see <https://www.gnu.org/licenses/>.
6
7	using System;
8	using System.Collections.Generic;
9	using Rdmp.Core.Curation;
10	using Rdmp.Core.ReusableLibraryCode;
11	using Rdmp.Core.ReusableLibraryCode.Checks;
12	using Rdmp.Core.ReusableLibraryCode.DataAccess;
13
14	namespace Rdmp.Core.Ticketing;
15
16	/// <summary>
17	/// Simple implementation of an RDMP ticketing system. Opens a browser
18	/// at the Url + ticket name. Has no validation restrictions based on
19	/// ticket states.
20	/// </summary>
21	public class SimpleTicketingSystem : ICheckable, ITicketingSystem
22	{
23	protected IDataAccessCredentials Credentials { get; set; }	×
24	protected string Url { get; set; }	×
25
26	protected SimpleTicketingSystem(TicketingSystemConstructorParameters parameters)	×
27	{
28	Credentials = parameters.Credentials;	×
29	Url = parameters.Url;	×
30	}	×
31
32	public void Check(ICheckNotifier notifier)
33	{
34	// all ticket names are valid
35	}	×
36
37	public bool IsValidTicketName(string ticketName) =>
38	// all ticket names are valid
39	true;	×
40
41	public void NavigateToTicket(string ticketName)
42	{
43	// if the user has added a URL just append the ticket name to it
44	// and open e.g. "www.myticketing?q=" + "HDD-123"
45	if (!string.IsNullOrWhiteSpace(Url))	×
46	UsefulStuff.OpenUrl(Url + ticketName);	×
47	}	×
48
49	public TicketingReleaseabilityEvaluation GetDataReleaseabilityOfTicket(string masterTicket, string requestTicket,
50	string releaseTicket, List<TicketingSystemReleaseStatus> acceptedStatuses, out string reason, out Exception exception)
51	{
52	reason = null;	×
53	exception = null;	×
54	// No restrictions on releasability
55	return TicketingReleaseabilityEvaluation.Releaseable;	×
56	}
57
58	public string GetProjectFolderName(string masterTicket) =>
59	UsefulStuff.RegexThingsThatAreNotNumbersOrLettersOrUnderscores.Replace(masterTicket, "");	×
60
61	public List<string> GetAvailableStatuses()
62	{
NEW 63	return new List<string>();	×
64	}
65	}

HicServices / RDMP / 9988321408

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous