wger-project / flutter / 9953483911

50%

master: 56%

Build Type

Pull #613

github

Committed by Dieterbe

Commit Message

refactor

ingredient details dialog:
 - give it close/continue buttons to load into selection
 - always use image property from loaded ingredient
   this is a bit slower, but:
   * more consistent (no need to support absolute vs relative URL's
     separately)
   * cleaner (no need to pass it thru explicitly)
   * more future proof: we will get rid of the dedicated
     /ingredient/search endpoint which gives us images before we load
     the full ingredient. in the future we will simply load the
     ingredients, completely, all at once.
   * allows for easier code reuse with barcode scan result dialog

barcode scan result dialog:
 - show image and detailed nutrition table
 - support a loading spinner
 - simplify error handling
 - deduplicate code between found & not found
 - share code with ingredient details dialog

Pull Request Pull Request #613: popup ingredient details in typeahead suggestions and recently used

Run Details

66 of 155 new or added lines in 9 files covered. (42.58%)

2 existing lines in 2 files now uncovered.

4161 of 8260 relevant lines covered (50.38%)

1.46 hits per line