weldr / lorax / 9947127925

42%

push

github

Prepare for the sbin merge

When packages are rebuilt in an environment with merged sbin, files move
from /usr/sbin to /usr/bin. 'runtime-cleanup' was wreaking havoc on such
installations, removing 'losetup', 'mkswap', and other crucial utilities.
(https://bodhi.fedoraproject.org/updates/FEDORA-2024-3aafcac6a8#comment-3609189)

The rules for the change:
- for single names, /sbin/ is replaced by /*bin/. E.g.
  /usr/sbin/chpasswd → /usr/*bin/chpasswd. This is easy, because we want
  to match 'chpasswd' no matter where it is installed.
- in some cases, there was a glob, but the rpm only has files
  in /usr/sbin, so we can apply the same substition and match those files
  no matter where they are installed.
- in some other cases, there was a glob, but it only matched a single
  file in /usr/sbin, and the package has other files in /usr/bin. In
  those cases, we need to adjust the glob to be more specific, e.g.
  /usr/sbin/* → /usr/*bin/iconvconfig for glibc.

This should be safe with unmerged packages, and should unbreak builds on
with merged packages.

591 of 1561 branches covered (37.86%)

Branch coverage included in aggregate %.

1634 of 3559 relevant lines covered (45.91%)

0.46 hits per line