IGVF-DACC / igvf-ui / #4154

100%

main: 100%

push

IGVF-1702 Limit number of selectable report columns (#553)

* Disable column checkboxes after selecting 100 of them.
* Move responsibility for disabling non-visible column checkboxes from column-selector.js to multireport.js. Move Javascript functions from multireport.js to /lib/report.ts.
* Show All columns now only adds columns until hitting the maximum allowable. Change the maximum allowable from 100 (50 for testing) to 120 because the when you get a report for `type=Item` you get 109 columns by default.
* Add a count of the number of visible columns to the footer of the column-selection modal.
* Add Jest tests for the new /lib/report.ts functions, and for disabled Checkbox components.
* Sort the column specs according to the title, or the column property name.
* Show the ID checkbox as selected and disabled, instead of hiding it. That lets the column counter message in the footer make more sense.
* Fix issue with the visible columns including columns not in schema-generated column list.
* Add Jest tests for new functionality. Update Cypress search test to remove no-longer-relevant checks.

1056 of 1056 branches covered (100.0%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 3 files covered. (100.0%)

2454 of 2454 relevant lines covered (100.0%)

16.46 hits per line