rust-bitcoin / rust-bitcoin / 9940712364

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2981: Remove to/from/as_raw_hash functions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2b56f763d0259e1a9a53e73439eafe990d65db17">2b56f763d hashes: Remove to/from/as_raw_hash (Tobin C. Harding)

Pull request description:

  In an effort to shrink the API of `hashes` remove the `from_raw_hash`, `to_raw_hash`, and `as_raw_hash` inherent functions from types created with the `hash_newtype` macro.

  There are a few reasons why this is favourable:

  - It allows stable crates to use the macro and not expose unstable `hashes` types in their API.
  - It makes types created with the macro less "general" in the sense that its more obscure to just hash any data into them. This allows us to write cleaner APIs in `rust-bitcoin`.

ACKs for top commit:
  Kixunil:
    ACK 2b56f763d0259e1a9a53e73439eafe990d65db17
  apoelstra:
    ACK 2b56f763d0259e1a9a53e73439eafe990d65db17

Tree-SHA512: 3d73aa82582526b35302342804c5dd5cb91

19623 of 23595 relevant lines covered (83.17%)

15635.02 hits per line