rust-bitcoin / rust-bitcoin / 9931005662

83%

push

github

Merge rust-bitcoin/rust-bitcoin#3009: Remove midstate from the `GeneralHash` and `HashEngine` traits

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8dcecfc144673300a630d9cbd716cadecf68d0d1">8dcecfc14 Remove midstate from the GeneralHash and HashEngine traits (Tobin C. Harding)

Pull request description:

  Midstates are not generic objects; they don't have universal cryptographic properties and if you are using them you should be using a specific midstate type. Therefore it shouldn't be part of `GeneralHash` or `HashEngine`. Furthermore, in practice it seems like `sha2` midstates are the only ones that anybody uses, at least in bitcoin.

  Remove the midstate stuff from the `GeneralHash` and `HashEngine` traits. Keep the `midstate` functionality as inherent functions if it is used internally. Keep the functionality on `sha256` as inherent public functions.

  Done as a first step towards #2918.

ACKs for top commit:
  apoelstra:
    ACK 8dcecfc144673300a630d9cbd716cadecf68d0d1
  Kixunil:
    ACK 8dcecfc144673300a630d9cbd716cadecf68d0d1

Tree-SHA512: 495fe6a4d377eb7e6d8d5a9cbc5f2e32dc0

14 of 14 new or added lines in 4 files covered. (100.0%)

19634 of 23612 relevant lines covered (83.15%)

15637.25 hits per line