uber / cadence-java-client / 2420

80%

Build Type

push

buildkite

Committed by web-flow

Commit Message

Use the same Request ID for retries (#915)

Currently the RequestId is initialized in the implementation of IWorkflowService (either Thrift2ProtoAdapter or WorkflowServiceTChannel). Since retries are handled within GenericWorkflowClientExternalImpl, each retry uses a different request ID. This causes Cadence's idempotency feature not to work correctly for retries from the Java client.

Move Request ID initialization to GenericWorkflowClientExternalImpl, and for backwards compatibility (since users may be interacting with the IWorkflowService directly) continue setting the request ID if not specified.

Run Details

14 of 27 new or added lines in 3 files covered. (51.85%)

3 existing lines in 2 files now uncovered.

12088 of 19489 relevant lines covered (62.02%)

0.62 hits per line