shinghim / rust-bitcoin / 9908889081

84%

push

github

Merge rust-bitcoin/rust-bitcoin#2996: Add alloc feature to `base58`, `addresses`, and `primitives`

<a class=hub.com/shinghim/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/shinghim/rust-bitcoin/commit/dc96475f58d4593a5fc29cfb858e0311ded69b87">dc96475f5 Add/fix alloc features (Tobin C. Harding)

Pull request description:

  Eventually we would like all our crates other than `bitcoin` to be able to be used without an allocator. Currently, and during crate smashing, this is not that useful because so much of the code comes from `bitcoin` and relies on the availability of an allocator.

  As an initial step, add the `alloc` feature to `addresses` , `base58`, and `primitives`.

  In order to to keep `--no-default-features` builds working make the crates empty if the `alloc` feature is not enabled. This is a suboptimal solution because the error messages users will get when they forget to enable `alloc` will be confusing (eg something like primitives does not contain Transaction). However our CI script (`run_task.sh`) expects `--no-default-features` to build cleanly (as do I).

ACKs for top commit:
  apoelstra:
    ACK dc96475f58d4593a5fc29cfb858e0311ded69b87
  Kixunil:
    ACK dc96475f58d4593a5fc29cfb858e0311ded69b87

Tree-SHA512: 28006ad637e7ad0d082c5ac9e2b957ae3a2

19587 of 23572 relevant lines covered (83.09%)

15711.95 hits per line