supabase / auth / 9905844632

69%

push

github

fix: omit empty string from name & use case-insensitive equality for comparing SAML attributes (#1654)

## What kind of change does this PR introduce?
* Fixes an issue where the SAML mapping is incorrect when a `Default` is
specified in the mapping and the `FriendlyName` in the SAML Assertion is
an empty string
* Use case-insensitive equality for mapping SAML attributes
* Tested with a trial okta account

## What is the current behavior?
* During the SAML assertion process, the `SAMLAttributeMapping` struct
defaults the `Name` to an empty string. When combined with a SAML
assertion that has an empty string set in the `FriendlyName`, this
causes an incorrect mapping when a default mapping is provided. (see
[test
case](https://github.com/supabase/auth/pull/1654/files#diff-e708a133546b94cdf6bf5f566640f7a3cR247-R272)
* Use case-sensitive equality for mapping SAML attributes

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.

5 of 5 new or added lines in 1 file covered. (100.0%)

8815 of 15191 relevant lines covered (58.03%)

54.74 hits per line