Kong / ngx_wasm_module / 9877542181

95%

Build Type

push

github

Committed by thibaultcha

Commit Message

fix(proxy-wasm) only inject shim headers after on_response_headers

Due to some Nginx internals (some response headers are added after our
module is executed but before the response is sent) we inject "shim
headers" into the `get_http_response_headers()` API. Some heuristics are
used to determine whether or not `Transfer-Encoding`, `Connection`, or
other "last minute" headers will be injected or not.

The issue is that the heuristics used are only valid during response
production and after (e.g. `r->chunked` or
`r->headers_out.content_length_n` may only be relevant during response
production). If a user uses `get_http_response_headers()` in request
phases, the returned headers may include elements that will not actually
be included in the response (e.g. `Transfer-Encoding`).

We now enforce that shim response headers should only be injected during
and after `on_http_response_headers`.

Run Details

7 of 0 new or added lines in 0 files covered. (NaN%)

1 existing line in 1 file now uncovered.

8703 of 9535 relevant lines covered (91.27%)

81312.52 hits per line