tarantool / luajit / 9873466312

93%

tarantool/master: 93%

Build Type

push

github

Committed by ligurio

Commit Message

FFI: Turn FFI finalizer table into a proper GC root.

Reported by Sergey Bronnikov.

(cherry picked from commit f5affaa6c)

Previous patch fixes the problem partially because the introduced
GC root may not exist at the start phase of the GC cycle. In that
case, the cdata finalizer table will be collected at the end of
the cycle. Access to the cdata finalizer table exhibits heap use
after free. The patch turns the finalizer table into a proper
GC root. Note, that finalizer table is created on the
initialization of the main Lua State instead of loading the FFI
library.

Sergey Bronnikov:
* added the description and the tests for the problem

Part of tarantool/tarantool#10199

Run Details

5674 of 6025 branches covered (94.17%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 5 files covered. (100.0%)

18 existing lines in 5 files now uncovered.

21653 of 23431 relevant lines covered (92.41%)

2941091.57 hits per line