uber / cadence-java-client / 2414

61%

master: 80%

Build Type

Pull #914

buildkite

Committed by natemort

Commit Message

Remove Reflection from CheckedExceptionWrapper

CheckedExceptionWrapper#unwrap currently uses reflection to rewrite the chain of Exceptions to remove all instances of CheckedExceptionWrapper. This approach is nonstandard to how Exception wrapping usually works in Java, and isn't friendly with the encapsulation in Java 17. Rather than trying to work around it, remove the behavior.

RpcRetryer was particularly impacted because both it and CompletableFuture wrap exceptions. Refactor it to avoid wrapping them using CheckedExceptionWrapper so that the final exception remains the same.

Pull Request Pull Request #914: [Breaking Change] Remove Reflection from CheckedExceptionWrapper

Run Details

15 of 16 new or added lines in 2 files covered. (93.75%)

1 existing line in 1 file now uncovered.

11936 of 19424 relevant lines covered (61.45%)

0.61 hits per line