ROVI-org / auto-soh / 9863792625

95%

Build Type

push

github

Committed by web-flow

Commit Message

ECM Dynamics and Simulator fully separate (#20)

* Fixes to the provide template functionality

The method had the old name, and used the old field names (capitalized). That has
been rectified.

* Additional bug fixes

RC components were still using lower case field names.

* Making main functions static methods + bug fixes

Since the transient update and the terminal voltage calculation no longer use
internal parameters (as there are none!), it makes sense for these to be static
methods (we no longer need to instantiate an ECM object that doesn't store
anything). Minor bug fixes were also performed (recall Coulombic efficiency was
its own HealthVariable).

* We now have an ECM simulator

This new class will take care of storing transient states, inputs, outputs, etc.
It can be used as a synthetic data generator as well as an ECM simulator.

* ECM simulator can now  keep its history

Added the possibility of keeping the full history in the simulator, including
inputs, transient states, and measurements. We are not keeping the A-SOH history
and for now, that does not change.

* Showing off simulator

Notebook now demonstrates how to use the ECM simulator.

* Adding markdown explanations

Moved comment explanations to markdown cells for nicer rendering.

* Removing init function

Since this class is not meant to be instantiated, and nothing happens upon
initialization, there is no need for an __init__ function.

* No more useless attributes

Previously, I was storing attributes that were not used anywhere else within the
class. That is no longer the case. This commit also comes with minor sytling
corrections.

* Removed inline comments

Before, I was using inline comments to explain what was happening in the update
of hysteresis. These have been moved to their own comment blocks.

* small linting change

* Fixing interpolator when base_vals not float

Before, if we were able to set an integer to ba... (continued)

Run Details

58 of 61 new or added lines in 5 files covered. (95.08%)

2 existing lines in 1 file now uncovered.

390 of 425 relevant lines covered (91.76%)

0.92 hits per line