comunica / comunica / 9852336308

100%

push

github

Fix initialBindings failing when done over projected variables

Changes include:

- Fixed an issue with `FILTER(false)` not filtering all results out:
    - Changed the `FilterPushdown` optimizer to not push down `FILTER(false)` except if it is wrapped around another `FILTER`.
- Handle projected variables that also appear in `InitialBindings`.
    -  Make `MaterializeOperation` add a `VALUES` clause for these variables instead of replacing them with their values.
- Fix '$' variables in `VALUES`
    - Fix an issue where variables written with '$' instead of '?' within a `VALUES` clause weren't being parsed as variables.

Closes #1298

2704 of 2704 branches covered (100.0%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 2 files covered. (100.0%)

8808 of 8808 relevant lines covered (100.0%)

5032.55 hits per line