rust-bitcoin / rust-bitcoin / 9846738129

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2889: Move `serde_round_trip` macro to internals

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7fa53440dc9c81d0e4b74eea21c9ca725a917ceb">7fa53440d Move serde_round_trip macro to internals (Tobin C. Harding)

Pull request description:

  We currently duplicate the serde_round_trip macro in `units` and `bitcoin`, this is unnecessary since it is a private test macro we can just throw it in `internals`.

  While we are at it lets improve the macro by testing a binary encoding also, elect to use the `bincode` crate because we already have it in our dependency graph.

  Add `test-serde` feature to `internals` to feature gate the macro and its usage (preventing the transient dependency on `bincode` and `serde_json`).

ACKs for top commit:
  Kixunil:
    ACK 7fa53440dc9c81d0e4b74eea21c9ca725a917ceb
  apoelstra:
    ACK 7fa53440dc9c81d0e4b74eea21c9ca725a917ceb

Tree-SHA512: f40c78bf2bad7b3f866c372a2c64ffd602c

19521 of 23501 relevant lines covered (83.06%)

15646.51 hits per line