ovn-org / ovn-kubernetes / 9801202042

53%

Build Type

push

github

Committed by jcaamano

Commit Message

Refactor NAD controller: Do not attach to default network

Default network does add NADs.
This is a follow up from PR https://github.com/ovn-org/ovn-kubernetes/pull/4461.

This change addresses the following panic:

Image built from ovn-kubernetes ref: refs/heads/master  commit: 0a6853062

I0703 14:17:52.721946      52 shared_informer.go:311] Waiting for caches to sync for [cluster-manager NAD controller]
I0703 14:17:52.721970      52 shared_informer.go:318] Caches are synced for [cluster-manager NAD controller]
panic: unexpected call for default network

goroutine 89 [running]:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util.(*DefaultNetInfo).AddNADs(0x205a120?, {0xc0005d6d50?, 0x23f9ce2?, 0x7?})
    /builds/nithyar/ovn_upstream_validation/ovn-kubernetes/go-controller/pkg/util/multi_network.go:148 +0x25

github.com/ovn-org/ovn-kubernetes/go-controller/pkg/network-attach-def-controller.(*NetAttachDefinitionController).syncNAD(0xc0004c1630, {0xc000e3ae40, 0x13}, 0x43e02e?)
    /builds/nithyar/ovn_upstream_validation/ovn-kubernetes/go-controller/pkg/network-attach-def-controller/network_attach_def_controller.go:243 +0x67b

github.com/ovn-org/ovn-kubernetes/go-controller/pkg/network-attach-def-controller.(*NetAttachDefinitionController).syncAll(0xc0004c1630)
    /builds/nithyar/ovn_upstream_validation/ovn-kubernetes/go-controller/pkg/network-attach-def-controller/network_attach_def_controller.go:139 +0x2ba

github.com/ovn-org/ovn-kubernetes/go-controller/pkg/controller.StartWithInitialSync(0xc000e03e08, {0xc00050bdf8, 0x1, 0x0?})
    /builds/nithyar/ovn_upstream_validation/ovn-kubernetes/go-controller/pkg/controller/controller.go:293 +0x18e

github.com/ovn-org/ovn-kubernetes/go-controller/pkg/network-attach-def-controller.(*NetAttachDefinitionController).Start(0xc0004c1630)
    /builds/nithyar/ovn_upstream_validation/ovn-kubernetes/go-controller/pkg/network-attach-def-controller/network_attach_def_controller.go:100... (continued)

Run Details

1 of 4 new or added lines in 1 file covered. (25.0%)

11 existing lines in 3 files now uncovered.

28953 of 54983 relevant lines covered (52.66%)

99.63 hits per line