grip-on-software / data-gathering / 9796409990

84%

push

github

Update schemas

- Add mapping between schema file and data file
- Add maximum lengths of fields based on database schema
- Add ranges for integers/longs based on how they are read by importer
- Add required properties based on importer needs
- Denote that additional properties must not be large integers/longs,
  arrays or objects, to avoid not being readable by (buffered) JSON
  reader in importer.
- Limit stringified integers to a length and to ASCII digits to avoid
  parsing problems in the importer.
- Adjust patterns for date and time that are not strictly ISO8601 due to
  use of spaces or limited to year-month, as these cannot be combined
  with a "format" option (or implementations cannot validate anything).
  Instead ensure the patterns validate the bare minimum for the importer
  to parse the string into an SQL timestamp object.
- Correct recursive reference in Jira comments
- Move nested objects to their own definitions
- Add a pattern for metric names to indicate they are normal ASCII names
- Avoid problems with references next to anyOf with references
- Indicate that metric targets can be empty strings
- Correct required properties location in quality update
- Correct VCS commit comment type
- Correct type of VCS versions metrics, which allowed hexadecimal values
- VCS versions now validate that if the "size" is included in the object
  then all the other metrics must also be there. This could be done with
  the "dependentRequired" option, but we try to be compatible with early
  drafts of the JSON schema and implementations, so we use "if"/"then".

2613 of 3355 branches covered (77.88%)

Branch coverage included in aggregate %.

8723 of 10252 relevant lines covered (85.09%)

1.7 hits per line