rust-bitcoin / rust-bitcoin / 9795105132

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2951: Fix `Amount` decimals handling

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3196c271acefe2b68783c8bc128c75942c978ba2">3196c271a<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/014c4931be9edb530b1db15e14feeca5506cad6b"> Deprecate `Amount::fmt_value_in` (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/467546fc0c13c9ed75ce26fa76252d363c4d07e7">467546fc0</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/014c4931be9edb530b1db15e14feeca5506cad6b"> Round `Amount` when requested precision is too low (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7c95a777c1435eb1aa53705fb97ed02411853614">7c95a777c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/014c4931be9edb530b1db15e14feeca5506cad6b"> Fix `Amount` decimals handling (Martin Habovstiak)

Pull request description:

  Displaying with minimal number of zeros is the default in Rust and we want to follow it. This was originally implemented in #716 but #2604 reversed it claiming this is common, however it broke people who rely on minimal display (e.g. BIP21) without fixing the root cause of #2136.

  This reverts commit </a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d887423efcdad8db4c60ffe61f53d2356c82c87c">d887423ef adds a test to prevent this change and also fixes the problem with `{:0.8}` not working.

  Closes #2136
  Closes #2948

  Can we backport this one too?

ACKs for top commit:
  tcharding:
    ACK 3196c271acefe2b68783c8bc128c75942c978ba2
  apoelstra:
    ACK 3196c271acefe2b68783c8bc128c75942c978ba2 I also really like how this reduces the complexity of the module, basically passing everything through to `display_in`

Tree-SHA512: 3221f8308bba12096011b515d4662cf7b6a

Run Details

27 of 28 new or added lines in 1 file covered. (96.43%)

17 existing lines in 1 file now uncovered.

19504 of 23515 relevant lines covered (82.94%)

15653.76 hits per line