Qiskit / qiskit / 9784710891

90%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Optimize DAGCircuit.collect_1q_runs() filter function (#12719)

In the recently merged #12650 a new rust function was added for the
filter function of the collect_1q_runs() method's internal filter
function. As part of this we need to do exclude any non-DAGOpNode dag
nodes passed to the filter function. This was previously implemented
using the pyo3 extract() method so that if the pyobject can be coerced
into a DAGOpNode for later use we continue but if it errors we know the
input object is not a DAGOpNode and return false. However, as we don't
need to return the error to python we should be using downcast instead
of extract (as per the pyo3 performance guide [1]) to avoid the error
conversion cost. This was an oversight in #12650 and I only used
extract() out of habit.

[1] https://pyo3.rs/v0.22.0/performance#extract-versus-downcast

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

65135 of 72496 relevant lines covered (89.85%)

294751.16 hits per line