rust-bitcoin / rust-bitcoin / 9763162782

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2940: Revert "bug fix" (actually a bug) from #2655

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7f024c333e68a2bbb4e898424366bb9ae99da1cc">7f024c333 Revert "bug fix" (actually a bug) from #2655 (Martin Habovstiak)

Pull request description:

  In a2b019f82 it was claimed that losing the input string without alloc is a bug. It is not, because allowing no-alloc is desired and there's no way to have the input string otherwise so we just accept it'll be missing and modify the messages accordingly. The commit that forced alloc was also horribly misleading since it kept the `alloc` feature but it makes this one easier.

  Note that input string is still present by default in all configurations except for no-alloc.

  I think we should also backport this and release fixed `units` because of the misleading `alloc` feature in them. Although it's not urgent. The only crate I know of that is kinda broken by it is `ln_types` which is already broken by depending on old `bitcoin`.

ACKs for top commit:
  apoelstra:
    ACK 7f024c333e68a2bbb4e898424366bb9ae99da1cc
  tcharding:
    ACK 7f024c333e68a2bbb4e898424366bb9ae99da1cc

Tree-SHA512: 014ed823f53b09655608542fd7c82be7719

19510 of 23505 relevant lines covered (83.0%)

15667.18 hits per line