hicommonwealth / commonwealth / 9750544166

38%

Build Type

push

github

Committed by web-flow

Commit Message

Fixes for session keys after v0.10 Canvas upgrade (#8210)

* fixes for keplr/metamask-evm login, fix for signed-out state when ENFORCE_SESSION_KEYS is off

* fixes for SessionRevalidationModal

* copy and design revisions for SessionRevalidationModal

* don't show SessionRevalidationModal if ENFORCE_SESSION_KEYS isn't set

* type fix

* revert changes to chain ids

* only validate comment signature validity if enforceSessionKeys = true

* revert reduced verifyAddress requirements from v0.10 upgrade

* remove error message when client-side verification fails

* remove @ts-expect-error StrictNullChecks where possible

* lint fix

* change variable name for clarity

* upgrade to canvas v0.10.0-beta.3 to catch siwe signatures with incorrect topic

* add verifyAddress tests for ethereum

* lint fixes

* Update packages/commonwealth/server/util/verifySessionSignature.ts

Co-authored-by: Timothee Legros <62490329+timolegros@users.noreply.github.com>

* Update packages/commonwealth/server/util/verifySessionSignature.ts

Co-authored-by: Timothee Legros <62490329+timolegros@users.noreply.github.com>

---------

Co-authored-by: Jake Naviasky <jake@commonwealth.im>
Co-authored-by: Timothee Legros <62490329+timolegros@users.noreply.github.com>

Coverage Stats

3544 of 22977 branches covered (15.42%)

Branch coverage included in aggregate %.

13 of 31 new or added lines in 9 files covered. (41.94%)

3 existing lines in 2 files now uncovered.

4862 of 34541 relevant lines covered (14.08%)

4.72 hits per line