Qiskit / qiskit / 9745535699

88%

Build Type

push

github

Committed by web-flow

Commit Message

Encapsulate Python sequence-like indexers (#12669)

This encapsulates a lot of the common logic around Python sequence-like
indexers (`SliceOrInt`) into iterators that handle adapting negative
indices and slices in `usize` for containers of a given size.

These indexers now all implement `ExactSizeIterator` and
`DoubleEndedIterator`, so they can be used with all `Iterator` methods,
and can be used (with `Iterator::map` and friends) as inputs to
`PyList::new_bound`, which makes code simpler at all points of use.

The special-cased uses of this kind of thing from `CircuitData` are
replaced with the new forms.  This had no measurable impact on
performance on my machine, and removes a lot noise from error-handling
and highly specialised functions.

Run Details

192 of 236 new or added lines in 4 files covered. (81.36%)

12 existing lines in 2 files now uncovered.

64400 of 71690 relevant lines covered (89.83%)

300676.37 hits per line