openSUSE / agama / 9743056713

72%

push

github

fix(storage): avoid segmentation fault when generating actions (#1419)

## Problem

The generation of the storage actions was fixed to avoid a segmentation
fault while accessing to the `CompoundAction` objects, see
https://github.com/openSUSE/agama/pull/1410. But there is still a chance
to reference to an actiongraph removed by the ruby GC.

~~~ruby
target_graph.actiongraph.compound_actions.map do |action|
  GC.start
  Action.new(a)
end
~~~ 

The actiongraph object could be dropped by the garbage collector while
iterating the list of compound actions.

## Solution

Keep a reference to the actiongraph, ensuring the actiongraph object is
not removed while generating the list of actions.

Note: once the list of actions is generated, the actiongraph is not
needed anymore because the `Action` objects do not keep a reference to
the source compound action, see
https://github.com/openSUSE/agama/pull/1410.

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

19584 of 27341 relevant lines covered (71.63%)

34.48 hits per line