safe-global / safe-core-sdk / 9742471451

78%

main: 78%

push

github

feat(api-kit): Support for SafeOperation confirmations endpoints (#876)

* Add confirmSafeOperation function

Calls the transaction-service's `POST /v1/safe-operations/{safe_operation_hash}/confirmations/` endpoint.

* Add getSafeOperationConfirmations function

Calls the transaction-service's `GET /v1/safe-operations/{safe_operation_hash}/confirmations/` endpoint.

* Small import fixes

* Reset sinon history after each api-kit endpoint test

Fix endpoint test for `confirmTransaction`

* Add endpoint tests for SafeOperation confirmations endpoints

* Add e2e tests for `getSafeOperationConfirmations`

* Add e2e tests for `confirmSafeOperation`

* Small fix in test description

* Small fix

* Use generic type `ListResponse` for safe-transaction-service related types

* Add `chainId` to SafeOperation type

* Change signature of function `getSafeOperationConfirmations`

* Change limit + offset type to number for `getSafeOperationConfirmations`

* Use ListOptions type also for other api-kit functions

This changes the type for `limit` + `offset` from string to number for the functions:
* getSafeDelegates
* getMessages
* getSafeOperationsByAddress

---------

Co-authored-by: Daniel <25051234+dasanra@users.noreply.github.com>

227 of 364 branches covered (62.36%)

Branch coverage included in aggregate %.

18 of 31 new or added lines in 3 files covered. (58.06%)

774 of 929 relevant lines covered (83.32%)

3.21 hits per line