rust-bitcoin / rust-bitcoin / 9724271866

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2932: Remove `bech32` dependency from `blockdata`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/010141ecc9a96b0d019c1cca1ef67a95e7b3f623">010141ecc<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/35202ba51bef3236e6ed1007a0d2111265b6498c"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/cf800a1b07133e159f1a65bfbeb50ebaf68cb06d">cf800a1b0</a> Remove bech32 dependency from blockdata (Tobin C. Harding)

Pull request description:

  We have a single usage of the `bech32` crate inside the `blockdata` module, to convert a `WitnessVersion` to a `Fe32`. We then have a single call site where we use the conversion in the `address` module.

  This code was written without thinking to hard about the introduced dependency on `bech32`, in hindsite it shouldn't have been added.

  In preparation for splitting a bunch of code in `blockdata` out into the `primitives` crate remove the `bech32` stuff from the `witness_version` module.

ACKs for top commit:
  Kixunil:
    ACK 010141ecc9a96b0d019c1cca1ef67a95e7b3f623
  apoelstra:
    ACK 010141ecc9a96b0d019c1cca1ef67a95e7b3f623

Tree-SHA512: 2d368ebf681a988ff954c52595825285670

3 of 3 new or added lines in 1 file covered. (100.0%)

19508 of 23494 relevant lines covered (83.03%)

15626.16 hits per line