unicode-org / icu4x / 9712070673

73%

Build Type

push

github

Committed by web-flow

Commit Message

Cleaning up `DataError` (#5146)

The variants are now:
* `MarkerNotFound`
* This was `MissingDataMarker`, unclear if it was missing from the
request or the data
* `IdentifierNotFound`
* This was `MissingLocale`, unclear if it was missing from the request
or the data, and needs to use identifier terminology
* ~`NeedsLocale`~
  * The locale is not optional, this was unused 
* `InvalidRequest`
* This was `ExtraneousLocale` but I think it should cover other illegal
requests as well
* `Filtered`
* This was `FilteredResource`, but we're not using resource terminology
anymore
* `InconsistentData`
* `Downcast`
* This was `MismatchedType`, but is only returned from
`AnyPayload::downcast` and `DowncastingAnyProvider`, so I think this is
a better name. Also more symmetric with ...
* `Deserialize`
* This was `UnavailableBufferFormat` or `Custom` before. Now all serde
issues return this variant, i.e. `DataPayload::deserialize` and
`DeserializingBufferProvider`
* `Custom`
* `Io`
* ~`MissingSourceData`~
* `DatagenProvider` is just one provider implementation, it can use
`Custom`

Run Details

32 of 368 new or added lines in 324 files covered. (8.7%)

13 existing lines in 5 files now uncovered.

53679 of 71426 relevant lines covered (75.15%)

561200.98 hits per line