• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / minder / 9710787513
53%

Build:
DEFAULT BRANCH: main
Ran 28 Jun 2024 09:49AM UTC
Jobs 1
Files 206
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Jun 2024 09:41AM UTC coverage: 52.439% (+0.007%) from 52.432%
9710787513

push

github

web-flow
Split message handling logic out of Executor (#3730)

Prior to this change, the interface of the Executor directly consumes
messages from a message queue, and then publishes its result to another
queue. This leads to some issues with testing:

1) The tests must be asynchronous in order to simulate event
   publishing. If the tests fail while running `make test`, the test
   hangs until the timeout happens.
2) Errors which take place inside the Executor get swallowed into the
   message and telemetry code, meaning that it's hard to figure out why
   exactly a test has failed.

This PR splits the Executor into two: the ExecutorEventHandler which
handles all interactions with message queues, and the Executor which
contains the logic for entity evaluation minus event handling.

The intention is that the tests for ExecutorEventHandler can use a mock
of the Executor. Since the message handling logic is unlikely to change
often, this should reduce the situations where the async tests fail and
we end up with long hangs in the test. This test cleanup work will be
implemented in a separate PR.

53 of 87 new or added lines in 3 files covered. (60.92%)

10978 of 20935 relevant lines covered (52.44%)

50.34 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9710787513.1 28 Jun 2024 09:49AM UTC 0
52.44
GitHub Action Run
Source Files on build 9710787513
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #9710787513
  • 674252be on github
  • Prev Build on main (#9710075212)
  • Next Build on main (#9739721509)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc