ooni / probe-cli / 9709859794

72%

push

github

fix(oonimkall): use richer-input-aware target loader (#1620)

This pull request fixes technical debt where `./pkg/oonimkall` ws using
custom code to load experiments targets rather than using a
(richer-input-aware) loader. We make sure to use a context with timeout
when loading.

Web Connectivity should continue to WAI on mobile after this change,
given that the app is calling check-in itself and it is still a
supported use case to execute an experiment with explicit input.

We also start preparing for simplifying both `./pkg/oonimkall` and the
mobile apps, by providing the category code and the country code inside
the `status.measurement_start` event, which will allow mobile apps to
update its URLs table in response to such event, rather than manually
calling the check-in API and providing inputs to the engine.

Closes https://github.com/ooni/probe/issues/2764

Closes https://github.com/ooni/probe/issues/2765

81 of 81 new or added lines in 2 files covered. (100.0%)

27934 of 33164 relevant lines covered (84.23%)

51.69 hits per line