#4068

Committed 28 Jun 2024 06:30AM UTC coverage: 49.072% (+0.2%) from 48.909%

Build # #4068

Build Type

push

github

Committed by

adangel

Commit Message

[plsql,tsql] Fix CPD being case sensitive in PLSQL and TSQL (#4943)

Merge pull request #4943 from oowekyala:issue4396-cpd-case-sensitive

Run Details

32306 of 71726 branches covered (45.04%)

Branch coverage included in aggregate %.

25 of 36 new or added lines in 6 files covered. (69.44%)

6528 existing lines in 6 files now uncovered.

68035 of 132753 relevant lines covered (51.25%)

0.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.86

/pmd-plsql/src/main/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexer.java

/*
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.plsql.cpd;

import net.sourceforge.pmd.cpd.CpdLanguageProperties;
import net.sourceforge.pmd.cpd.impl.JavaccCpdLexer;
import net.sourceforge.pmd.lang.LanguagePropertyBundle;
import net.sourceforge.pmd.lang.TokenManager;
import net.sourceforge.pmd.lang.ast.impl.javacc.JavaccToken;
import net.sourceforge.pmd.lang.document.TextDocument;
import net.sourceforge.pmd.lang.plsql.ast.InternalApiBridge;
import net.sourceforge.pmd.lang.plsql.ast.PLSQLTokenKinds;

/**
 * <p>Note: This class has been called PLSQLTokenizer in PMD 6</p>.
 */
public class PLSQLCpdLexer extends JavaccCpdLexer {

    private final boolean ignoreIdentifiers;
    private final boolean ignoreLiterals;

    public PLSQLCpdLexer(LanguagePropertyBundle properties) {
        /*
         * The Tokenizer is derived from PLDoc, in which comments are very
         * important When looking for duplication, we are probably not
         * interested in comment variation, so we shall default ignoreComments
         * to true
         */
        ignoreIdentifiers = properties.getProperty(CpdLanguageProperties.CPD_ANONYMIZE_IDENTIFIERS);
        ignoreLiterals = properties.getProperty(CpdLanguageProperties.CPD_ANONYMIZE_LITERALS);
    }

    @Override
    protected String getImage(JavaccToken plsqlToken) {
        String image;

        if (ignoreIdentifiers && plsqlToken.kind == PLSQLTokenKinds.IDENTIFIER) {
            image = "<identifier>";
        } else if (ignoreLiterals && (plsqlToken.kind == PLSQLTokenKinds.UNSIGNED_NUMERIC_LITERAL
            || plsqlToken.kind == PLSQLTokenKinds.FLOAT_LITERAL
            || plsqlToken.kind == PLSQLTokenKinds.INTEGER_LITERAL
            || plsqlToken.kind == PLSQLTokenKinds.CHARACTER_LITERAL
            || plsqlToken.kind == PLSQLTokenKinds.STRING_LITERAL
            || plsqlToken.kind == PLSQLTokenKinds.QUOTED_LITERAL)) {
            // the token kind is preserved
            image = PLSQLTokenKinds.describe(plsqlToken.kind);
        } else {
            image = plsqlToken.getImage();
        }
        return image;
    }

    @Override
    protected TokenManager<JavaccToken> makeLexerImpl(TextDocument doc) {
        return InternalApiBridge.newTokenManager(doc);
    }
}

1	/*
2	* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3	*/
4
5	package net.sourceforge.pmd.lang.plsql.cpd;
6
7	import net.sourceforge.pmd.cpd.CpdLanguageProperties;
8	import net.sourceforge.pmd.cpd.impl.JavaccCpdLexer;
9	import net.sourceforge.pmd.lang.LanguagePropertyBundle;
10	import net.sourceforge.pmd.lang.TokenManager;
11	import net.sourceforge.pmd.lang.ast.impl.javacc.JavaccToken;
12	import net.sourceforge.pmd.lang.document.TextDocument;
13	import net.sourceforge.pmd.lang.plsql.ast.InternalApiBridge;
14	import net.sourceforge.pmd.lang.plsql.ast.PLSQLTokenKinds;
15
16	/**
17	* <p>Note: This class has been called PLSQLTokenizer in PMD 6</p>.
18	*/
19	public class PLSQLCpdLexer extends JavaccCpdLexer {
20
21	private final boolean ignoreIdentifiers;
22	private final boolean ignoreLiterals;
23
24	public PLSQLCpdLexer(LanguagePropertyBundle properties) {	1✔
25	/*
26	* The Tokenizer is derived from PLDoc, in which comments are very
27	* important When looking for duplication, we are probably not
28	* interested in comment variation, so we shall default ignoreComments
29	* to true
30	*/
31	ignoreIdentifiers = properties.getProperty(CpdLanguageProperties.CPD_ANONYMIZE_IDENTIFIERS);	1✔
32	ignoreLiterals = properties.getProperty(CpdLanguageProperties.CPD_ANONYMIZE_LITERALS);	1✔
33	}	1✔
34
35	@Override
36	protected String getImage(JavaccToken plsqlToken) {
37	String image;
38
39	if (ignoreIdentifiers && plsqlToken.kind == PLSQLTokenKinds.IDENTIFIER) {	1!
NEW 40	image = "<identifier>";	×
41	} else if (ignoreLiterals && (plsqlToken.kind == PLSQLTokenKinds.UNSIGNED_NUMERIC_LITERAL	1!
42	\|\| plsqlToken.kind == PLSQLTokenKinds.FLOAT_LITERAL
43	\|\| plsqlToken.kind == PLSQLTokenKinds.INTEGER_LITERAL
44	\|\| plsqlToken.kind == PLSQLTokenKinds.CHARACTER_LITERAL
45	\|\| plsqlToken.kind == PLSQLTokenKinds.STRING_LITERAL
46	\|\| plsqlToken.kind == PLSQLTokenKinds.QUOTED_LITERAL)) {
47	// the token kind is preserved
48	image = PLSQLTokenKinds.describe(plsqlToken.kind);	1✔
49	} else {
50	image = plsqlToken.getImage();	1✔
51	}
52	return image;	1✔
53	}
54
55	@Override
56	protected TokenManager<JavaccToken> makeLexerImpl(TextDocument doc) {
57	return InternalApiBridge.newTokenManager(doc);	1✔
58	}
59	}

pmd / pmd / #4068

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous