realm / realm-core / 2444

91%

Build Type

push

Evergreen

Committed by web-flow

Commit Message

Fix compacting a Realm file using the existing encryption key (#7844)

`compact()` stored the existing encryption key in a `std::string`, which
expects a nul-terminated string, not a fixed-size buffer. If the key contained
any nul bytes then the key would be truncated and garbage data would be used as
the encryption key instead, and if it didn't then arbitrarily large additional
amounts of memory would also be copied into the buffer. The tests happened to
always use a nul-terminated string as the key and so worked by coincidence.

Run Details

102140 of 180396 branches covered (56.62%)

52 of 52 new or added lines in 5 files covered. (100.0%)

53 existing lines in 13 files now uncovered.

214756 of 236124 relevant lines covered (90.95%)

5736951.71 hits per line