babelfish-for-postgresql / babelfish_extensions / 9699198592

73%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Support CHECK CONSTRAINTS options and Fix Error aborting Cycle in TSQL Bulk Copy (#2691)

This commit has the following changes:

1. Fix Permissions checking missed in d95b7ad
2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase.
3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish.

Issues Resolved
BABEL-4200, BABEL-4991

Authored-by: Kushaal Shroff kushaal@amazon.com
Signed-off-by: Kushaal Shroff kushaal@amazon.com

Run Details

11 of 11 new or added lines in 3 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

41891 of 57360 relevant lines covered (73.03%)

109101.73 hits per line