rust-bitcoin / rust-bitcoin / 9699575953

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2921: Make 'use core::fmt' calls consistent

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8ee1744b9b0337c3fcf38f8da02735af6852c445">8ee1744b9 Make 'use core::fmt' calls consistent (Shing Him Ng)

Pull request description:

  I started taking a look at #2869 and looked for everything that was implementing the `Display` trait:

  ```rust
  impl fmt::Display for _
  ```

  but found some places where the imports weren't consistent:
  ```rust
  impl Display for _
  ```

  There were only a few instances of the latter, so I went ahead and cleaned those up before starting #2869

  I started pulling this thread when I saw the same thing was happening for `fmt::Debug` and `fmt::Formatter` so I updated the rest of the `use core::fmt::*` statements with a few exceptions:

  - No updates to `use core::fmt::*` if it was being called from within a function since I felt like the function scope was small enough to not cause confusion
  - No updates to `use core::fmt::{self, Write as _};`

ACKs for top commit:
  Kixunil:
    ACK 8ee1744b9b0337c3fcf38f8da02735af6852c445
  tcharding:
    ACK 8ee1744b9b0337c3fcf38f8da02735af6852c445

Tree-SHA512: 33eb6ea0c6c50d8048fd29be5e2ffc4c680

Run Details

3 of 6 new or added lines in 4 files covered. (50.0%)

1 existing line in 1 file now uncovered.

19508 of 23477 relevant lines covered (83.09%)

15693.04 hits per line