opengovsg / FormSG / 9691950472

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(admin-form): support nric masking (#7388)

* feat(admin-form): add frontend nric mask toggle to singpass auth settings

* fix(admin-form): fix spacing and change units from px to rem

* feat(admin-form): create isNricMaskingEnabled field in database when form is created

* feat(admin-form): enable fetching and updating isNricMaskingEnabled field in backend routes

* feat(admin-form): connect frontend component with server api routes

* fix(admin-form): make code terser, remove unused params, fix nullish-coalesce operator usage

* fix(admin-page): fix flickering bug

* feat(duplicate-api): implement duplication of isNricMaskEnabled field

* feat(public-form): prevent nric from reaching frontend if masked

* feat(nric-mask): apply masking when submitting forms

* feat(nric-mask): update frontend template to reflect masking toggle changes

* fix(index.html): checkout to develop branch

* fix: remove console.log

* fix(toggle-component): replace nullish coalesce with ternary operator

* chore(public-form-controller): remove masking when fetching public form at backend

* fix: refactor email-submission-controller to mask at single location

* fix: clean up nric-mask util function and unused imports

* fix: update field with evaluated map value

* feat: add nric masking to the frontend public form provider

* feat: remove tooltip and labelComponentRight from Toggle to match design

* feat: update settings auth page to reflect design master

* feat: add err message

* feat: change px to rem

* feat: disable independently for nric masking and auth toggle

* fix: change MyInfo to Myinfo in description message

* fix: update form model test suite to expect new isNricMaskEnabled field

* feat: add tests for nric mask util and masking for email submission

* feat: add test for isNricMaskDisabled for email submission

* feat: add tests for storage mode submission masking

* fix: fix bug with submission... (continued)

Run Details

2226 of 3763 branches covered (59.15%)

Branch coverage included in aggregate %.

10 of 11 new or added lines in 2 files covered. (90.91%)

112 existing lines in 3 files now uncovered.

9045 of 11594 relevant lines covered (78.01%)

39.66 hits per line