rust-bitcoin / rust-bitcoin / 9680946181

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2870: Remove `Denomination::MilliSatoshi`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/362c3b8772fe26aa6c84e8e1fd3d9cc6cb5384cb">362c3b877<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9a94166aee5b725c20fe7a520342dfecef2ff727"> api: Run just check-api (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9ea8c58ad6f077a8ff07a7ccec458959b120f075">9ea8c58ad</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/9a94166aee5b725c20fe7a520342dfecef2ff727"> Fix case sensitivity of denomination (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/67569ca632f4d3c74147efa442da4f81190f7725">67569ca63</a> Remove denominations < 1 satoshi (Jamil Lambert, PhD)

Pull request description:

  The denomination `MilliSatoshi` has been removed from `Amount`.

  `NanoBitcoin` and `PicoBitcoin` have also been removed since they are also less than 1 satoshi and the same reason for removing milliSatoshi in Issue #2820 should apply to them.

  The second patch fixes the way the denominations with various combinations of upper and lower case are handled when converted from a string.

  Close: #2820

ACKs for top commit:
  Kixunil:
    ACK 362c3b8772fe26aa6c84e8e1fd3d9cc6cb5384cb
  tcharding:
    ACK 362c3b8772fe26aa6c84e8e1fd3d9cc6cb5384cb

Tree-SHA512: d2dc23366cbe0139abcd7844422f1b50349

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

19508 of 23477 relevant lines covered (83.09%)

15666.61 hits per line