Qiskit / qiskit / 9680318090

88%

Build Type

push

github

Committed by web-flow

Commit Message

Simplify QuantumCircuit._from_circuit_data bit handling (#12661)

* Simplify QuantumCircuit._from_circuit_data bit handling

This commit simplifies the logic around bit handling in the
`QuantumCircuit._from_circuit_data()` constructor. Previously it was
calling `add_bits()` for each bit in the `CircuitData` object to update
the output circuit's accounting for each qubit. But this was needlessly
heavy as the `CircuitData` is already the source of truth for the bits
in a circuit and we just need to update the indices dictionary. The
`add_bits()` method attempts to add the bits to the `CircuitData` too
but this is wasted overhead because the `CircuitData` already has the
bits as that's where the came from. This changes the constructor to just
directly set the bit indices as needed and return the circuit.

* Use a dict comprehension instead of a for loop

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

9 existing lines in 2 files now uncovered.

63797 of 71062 relevant lines covered (89.78%)

307075.17 hits per line