trento-project / web / f7d600c7274b0d22c7fb1afdb363b7afc2093356

88%

Build Type

push

github

Committed by web-flow

Commit Message

Activity log retention time endpoint (#2702)

* Adds OpenAPI schema

Adds an OpenAPI schema for the Activity Log request/response object .

* Implements the controller actions

* Adds tests

* Adds test for 422 response

Adds test for scenario when update will not happen and return 422. Fixes controller code accordingly.

* Updates openapi schema

According to PR comments

* Addresses PR comments

Makes use of with clause instead of case statement

* Updates API shape

Due to PR comments, the retention settings are now nested one level deeper inside Activity Log settings, as opposed to being top level fields as was the case earlier.

* Adds a comment explaining the error rebinding

The comment explains why a context function's error response is rebound to another error message. Prompted by a PR comment.

* Adds missing end

Coverage Stats

12 of 12 new or added lines in 4 files covered. (100.0%)

1 existing line in 1 file now uncovered.

2450 of 2901 relevant lines covered (84.45%)

33.8 hits per line