openSUSE / agama / 9678883826

72%

Build Type

push

github

Committed by web-flow

Commit Message

Network improvements (#1365)

## Description

Network was one of the first components we added to Agama and since then
it the components have evolve a lot being one of the most out of date
ones. Therefore it was known it deserve some love... and we tried to
start revamping it a little bit.

**Changes done:**

- Modified the Network Page using routes instead of popup modals to
configure the connections or to connecto a WiFi network.
- Modified the wifi selection list and added a drawer for showing the
selected network description and connection options.
- Notify device state reason changes in order to detect an
authentication error when connecting to a WiFi (reopen the form is still
pending)
  - Fixed gateway4 set up.
  - Do not show externally configured connections (libvirt, vpns..)

Manually tested

**Pending:**

- Try to improve the state management as network changes usually close
de opened websocket opening the door to miss state changes
notifications. Because of that, the read of the devices, connections and
WiFi networks is done everytime insted of modifying the current state
with just the changes.
  - Show the form of the failing authentication WiFi.
  - Fix the unit tests.
  - Remove unnecesary files, and fix types descriptions.

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

15 of 45 new or added lines in 7 files covered. (33.33%)

234 existing lines in 10 files now uncovered.

19098 of 26852 relevant lines covered (71.12%)

34.47 hits per line