unicode-org / icu4x / 9663841484

73%

Build Type

push

github

Committed by web-flow

Commit Message

Explicit `LocaleFallbacker` argument for `DatagenDriver` (#5114)

Datagen implicitly requires a `LocaleFallbacker` for most
configurations, so I'd rather make it explicit so that providers that
don't expose fallback themselves are exportable.

I also removed the no-fallback mode, as that can (almost, up to
`["und"]`) be modeled by the fallback path, and made the required
settings arguments to `new`.

I also added a `supported_markers` method to the
`ExportableDataProvider` trait; datagen will by default now support all
available markers *for the provider*. This lets me remove the
`all_markers` methods from the driver crate, which didn't make sense
there. This allows removing the `all_markers`, `marker`, and `markers`
methods from `icu_datagen`, so that it's registry-agnostic.
`markers_for_bin` moves to `icu`, as that needs the `icu` crate anyway
and only supports markers in `icu`.

---------

Co-authored-by: Shane F. Carr <shane@unicode.org>

Run Details

70 of 139 new or added lines in 5 files covered. (50.36%)

23 existing lines in 10 files now uncovered.

53198 of 70892 relevant lines covered (75.04%)

564669.86 hits per line