rust-bitcoin / rust-bitcoin / 9637337111

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2896: Move `PushBytes::read_scriptint` outside of the `private` module

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/aebf21661984df45ff79826706f004425f765140">aebf21661<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ae8b0b1610a82624684a24d7cfda1106e1ff43c2"> Use 100 column width for rustdoc (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c71ae9ac165406d624766ca53e9b845cf439e9bd">c71ae9ac1</a> Move PushBytes::read_scriptint (Tobin C. Harding)

Pull request description:

  The `push_bytes` module has a `private` module that exists solely to protect the invariant on the `PushBytes` inner byte slice. There is a `PushBytes` impl block outside the private module for functions that can not and do not violate the length invariant.

  Recently we move the `read_scriptint` method to be on the `PushBytes` but we put it inside the `private` module, since the method only reads off of the slice it cannot invalidate the invariant and does not need to be inside the `private` module.

  Move the `read_scriptint` method outside of the `private` module to keep that module as small as possible, helping with its stated aim of being the only place that requires auditing.

  Patch 2 is whitespace only.

ACKs for top commit:
  Kixunil:
    ACK aebf21661984df45ff79826706f004425f765140
  apoelstra:
    ACK aebf21661984df45ff79826706f004425f765140

Tree-SHA512: f41eb691e15259f1c1acd0b4665a0ef9def

18 of 19 new or added lines in 1 file covered. (94.74%)

19539 of 23507 relevant lines covered (83.12%)

15683.23 hits per line