hack-pad / hackpadfs / 9635419975

73%

push

github

fix: fix field alignment to avoid panics on 32bit OSes (#44)

Fixes #43

To solve this:
- enabled the `fieldalignment` linter (which is a sub-linter of `govet`)
- ran the `fieldalignment -fix` command to fix misaligned structs that
were non-obvious
- switch from using e.g. `int64` + `atomic.StoreInt64` to using
`atomic.Int64` (etc) and because of this...
- drop Go 1.18 support, and require Go 1.19+ (where the new atomic types
were introduced)
- added a new CI job to test in a 32-bit container (so far just Intel
386, which should catch the same bugs as arm32/etc)
- added some new tests to cover `keyvalue/blob.Bytes`, which was what
was giving me trouble initially

---------

Signed-off-by: Dave Henderson <dhenderson@gmail.com>

6 of 6 new or added lines in 2 files covered. (100.0%)

1998 of 2751 relevant lines covered (72.63%)

392.09 hits per line