uber / cadence / 01903cd8-7566-49d3-8acb-d867ea03719f
71%
master: 72%

LAST BUILD BRANCH: fixit
DEFAULT BRANCH: master
Ran
Jobs 1
Files 720
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.481% (-0.02%) from 71.498%
01903cd8-7566-49d3-8acb-d867ea03719f

push

buildkite

web-flow 
Persist failover history in DomainInfo data (#6139)

**What changed?**
Added functionality to persist recent failover event data in the DomainInfo whenever a valid failover is executed.
`FailoverEvent` contains the failover `timestamp`, `fromCluster`, `toCluster`, and `FailoverType`("Force"/"Grace") information.
`FailoverHistory` is the key in the `DomainInfo` `data`. It's a slice stored as a string containing the `FailoverEvents`, with max size defined by `dynamicconfig.FrontendFailoverHistoryMaxSize`. It has a default value of 5 and domain filter allowed.
`FailoverHistory` always keep the n most recent `FailoverEvents` and it's sorted by descending timestamp.

**Why?**
Persist failover information, improving failover visibility to clients and the cadence team.

**How did you test it?**
Unit tests and integration tests. Tested locally, triggering failovers in a multiple Cadence clusters with replication environment.

**Potential risks**
The change does not affect the logic of UpdateDomain. It adds the failover info to the DomainInfo data. The main risk is that we introduce something that can cause the code to panic. Errors while adding the FailoverHistory are logged as warnings and do not return/interrupt the UpdateDomain action.

**Release notes**

**Documentation Changes**

27 of 39 new or added lines in 3 files covered. (69.23%)

58 existing lines in 11 files now uncovered.

106648 of 149198 relevant lines covered (71.48%)

2581.53 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
4
95.6
 -0.3% common/domain/handler.go
8
0.0
 common/constants.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
73.23
 -1.57% service/matching/tasklist/db.go
2
76.05
 -0.4% service/matching/tasklist/task_list_manager.go
3
50.46
 -0.55% common/log/tag/tags.go
3
85.52
 -1.01% common/persistence/nosql/nosql_task_store.go
3
69.23
 -3.85% tools/cli/admin_db_decode_thrift.go
3
85.57
 0.52% service/history/task/fetcher.go
4
45.35
 -0.79% common/types/history.go
4
80.41
 -4.12% common/task/fifo_task_scheduler.go
5
68.87
 -4.72% service/history/engine/engineimpl/record_activity_task_started.go
9
75.86
 -1.86% service/matching/tasklist/task_reader.go
20
70.57
 -5.71% service/history/task/task_util.go
Jobs
ID Job ID Ran Files Coverage
1 01903cd8-7566-49d3-8acb-d867ea03719f.1 720
71.48
Source Files on build 01903cd8-7566-49d3-8acb-d867ea03719f