safe-global / safe-client-gateway / 9582121482

89%

Build Type

push

github

Committed by web-flow

Commit Message

Limit maximum amount of TWAP parts (#1670)

Limits the number of parts we request up to 11 (confirmed by CoW) - which can be configured by an env. var. (`swaps.maxNumberOfParts`). If there are >11 parts, the final one is used to fetch the status and token information but it means that `executedSellAmount` and `executedBuyAmount` are `null` as we cannot calculate them:

- Add `swaps.maxNumberOfParts` configuration
- Update `TwapOrderInfo['executedSellAmount' | 'executedBuyAmount']` to be `string | null`
- Limit number of parts, fetching only the last if more than the maximum
- Add appropriate test coverage

Run Details

413 of 2443 branches covered (16.91%)

Branch coverage included in aggregate %.

5 of 11 new or added lines in 2 files covered. (45.45%)

1 existing line in 1 file now uncovered.

4071 of 6665 relevant lines covered (61.08%)

12.85 hits per line