opengovsg / FormSG / 9578005893

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat: email <> storage mode parity (#7350)

* feat: add basic email notifications page

* feat: update storage form types

* feat: update validation rules and add helper fns

* rename email notifications page name

* refactor tab rendering logic

* fix(admin-form): update Joi validation wrt emails and publicKey fields

Fixes #2264 by disallowing publicKey field for email mode forms and
disallowing emails field if not Email or Encrypt mode.

* feat(model): add emails field to encrypt forms

* fix(frontend): fix issue when getValues returns undefined

* refactor: make dataCollationData optional and add common types

* feat(encrypt-submission): update encrypt submissions to send email notifs

* fix: replace deprecated opaque type with tagged

* refactor: move email notifications and show payments tab by default

* fix: update mutations to fix failing validation at form wizard

* fix: remove unused type predicates

* feat(frontend): exclude email notifications from payment forms

* fix: move tabConfig to top level and separate label from path

* refactor: remove redundant useMemo and add EmailNotificationsHeader

* fix: update encrypt form validation to have string[] only

* fix(admin-form): enforce emails to be empty when duplicating to encrypt

* fix(test:backend): add and modify tests for emails field in encrypt form

* fix(test): ensure processDuplicateOverrideProps returns empty emails for encrypt

* fix(test): update ENCRYPT_FORM_DEFAULTS to have emails field

* fix: add exhaustive switch for enums

* fix: move boolean calc out and fix inline message in payments page for test env

* fix: update form encrypt schema

* fix: add PaymentsNotAllowed component

* fix: update comment for /settings controller and remove emails from duplicate dto

* fix(admin-form): validate that payment forms don't have emails and vice versa

* fix: add helper to extract emails from form types

* fix: cleanup

*... (continued)

Run Details

2202 of 3741 branches covered (58.86%)

Branch coverage included in aggregate %.

33 of 36 new or added lines in 9 files covered. (91.67%)

3 existing lines in 1 file now uncovered.

8975 of 11519 relevant lines covered (77.91%)

38.66 hits per line