goto / guardian / 9576502514

66%

Build Type

push

github

Committed by web-flow

Commit Message

fix(edit-appeal): check details interface recursively to validate if fields are changed (#157)

* feat(edit-appeal): check details interface recursively to validate if any field value is changed or not

* feat(edit-appeal): send pre condition failed error in case of no changes found

* chore: fixed go releaser version

* refactor: rely on approval.Index instead of array index when evaluating list of approvals

* chore: add TODO to check appeal.status directly

* fix: loop through approvals by policy steps

* fix: return next non-stale pending approval

* chore: add comment

* test: update test cases for update approval to cover appeal containing stale approvals

* test: update test cases for AdvanceApproval

* fix(diff): change default behavior and add tests

* refactor: fully use diff.Compare to compare old and new appeals

* refactor: move appeal diff logic to domain

* refactor: centralized appeal details reserved keys

---------

Co-authored-by: Ayushi Sharma <ayushi.sharma@gojek.com>
Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

Run Details

214 of 248 new or added lines in 5 files covered. (86.29%)

4 existing lines in 2 files now uncovered.

10073 of 13439 relevant lines covered (74.95%)

4.9 hits per line