qunitjs / qunit / 9556355311

90%

Build Type

push

github

Committed by Krinkle

Commit Message

Core: Expose QUnit.urlParams, fix preconfig conflict, set initial explicitly

* Always expose QUnit.urlParams

  Previously this API was left undefined in non-browser environments.
  To make usage easier and safer in environment-agnostic code,
  export the object always, with it remaining an empty object if
  globalThis.window.location is undefined.

* Fix broken preconfig for built-in urlConfig options.

  When the preconfig feature was first introduced in QUnit 2.1.0 (2016),
  it did not work for certain config keys. In urlparams.js we
  unconditionally re-assign some keys. Thus, even if preconfig sets
  one of these, and QUnit.urlParams does not, we'd effectively set it
  to undefined, wiping away the preconfig value.

  - QUnit.config.moduleId
  - QUnit.config.testId
  - QUnit.config.module
  - QUnit.config.filter

* Fix missing "unknown" option in custom menu defined by urlConfig.

  `let selection = false;` was scoped incorrectly in the urlConfig loop
  in html.js, causing it to only work for the first custom menu.

  When registering two or more custom menus, any non-first menu with
  an unknown value would be missing `<option selected disabled>c</option>`
  in the dropdown menu.

* Apply type validation for built-in curlConfig options. This fixes
  cases where, via urlParams, one could set a core config key to an
  invalid value (wrong type):

  - ?hidepassed=true (was string "true", now bool true)
    Previously, hidepassed=false was treated as truthy, which will now
    be treated as false/off.

    Invalid values like ?hidepassed=x will now also be treated as false.

    Since hidepassed=1 is not unheard of in the wild, this is
    now a supported boolean value.

  - ?filter=one&filter=two (was array, now undefined)
    Previously this would inject an invalid value, causing a runtime
    TypeError due to internal code calling String methods on it.

* Set the initial default values of `hidepassed`, `noglobals`, and
  `notrycatch` explicitly ... (continued)

Run Details

29 of 30 new or added lines in 4 files covered. (96.67%)

1 existing line in 1 file now uncovered.

1829 of 2049 relevant lines covered (89.26%)

2167.3 hits per line