9555575293
69%

Ran 17 Jun 2024 10:22PM UTC

Jobs 1

Files 122

Run time 1min

Badge

Embed ▾

Committed 17 Jun 2024 10:18PM UTC coverage: 56.362% (+0.04%) from 56.319%

Build # 9555575293

Build Type

push

github

Committed by

web-flow

Commit Message

Only use Vite in compose.dev.yaml (#1124)

We want demo users to be able to get started with nothing but a
`divviup` binary, a working Docker Compose install and `compose.yaml`.
`divviup_api_vite` relies on having a local checkout of the static
assets to serve. We now use the `diviup_api_integration_test` image to
serve static assets from service `static_assets`. The assets in question
are already present in the image being run in service `divviup_api`, but
I did it this way for the following reasons:

- `divviup-api` routes requests to the static asset handler based on
  hostname, making it difficult to serve alongside the API. I tried
  creating some aliases ([1]) in Docker Compose, but those names are
  only visible inside the compose network, meaning you have to set the
  `Host` header from outside the netns, which is a hassle I don't want
  to inflict on demo users.
- Having a distinct service for assets is convenient because we can make
  it depend on `pair_aggregators`. If that ran last, it could cause
  `docker compose up --wait` to fail (see comment in `compose.yaml`).

[1]: https://docs.docker.com/compose/compose-file/05-services/#aliases

Part of #1096

Coverage Stats

3938 of 6987 relevant lines covered (56.36%)

106.66 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	9555575293.1	17 Jun 2024 10:22PM UTC	0	56.36	GitHub Action Run

Source Files on build 9555575293

Detailed source file information is not available for this build.

divviup / divviup-api / 9555575293
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9555575293

divviup / divviup-api / 9555575293 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9555575293

divviup / divviup-api / 9555575293
69%

README BADGES
x